-
-
Notifications
You must be signed in to change notification settings - Fork 502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented mDNS #1441
Implemented mDNS #1441
Conversation
Moved mDNS code out of request handler, could not reproduce crash anymore. |
I cleaned it up a little bit more. I looked at some other projects that use esp32 and mDNS (like WLED for example), and they all only enable/disable mDNS on boot. This means that every time you'd change this option you would have to reboot. I never had problems with it when turning it on, so if there are problems I could rewrite it so that enabling will work, but disabling only works on boot. But imo it works fine like this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you mind combining the commits into one with git squash?
43a7295
to
ea34e38
Compare
@tbnobody Thanks for the Review, I have resolved all of the issues :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, just had to add some remarks (it triggered my "Internal Monk")
ea34e38
to
7c87518
Compare
Okay, fixed everything again 👍 |
Btw we should maybe link issue #1428 with this PR |
@tbnobody Any updates? |
It's already included in my local branch for several days. Just had no time for a release yet. Will (hopefully) publish it tomorrow or tuesday. |
Awesome, thank you very much! Have a nice evening |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns. |
This PR implements mDNS for OpenDTU. It adds two services, one for the commonly used _http._tcp service, and one custom one (_opendtu._tcp) for auto-discovery.
It also implements the needed changes for the Web-App.
Flash Statistics:
This PR was inspired by #695.