Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Fix the update URIs #61

Merged
merged 7 commits into from
Apr 8, 2021
Merged

[RFC] Fix the update URIs #61

merged 7 commits into from
Apr 8, 2021

Conversation

Shougo
Copy link
Contributor

@Shougo Shougo commented Apr 5, 2021

Fix #60

@Shougo Shougo changed the title Fix the update URIs [WIP] Fix the update URIs Apr 5, 2021
@Shougo
Copy link
Contributor Author

Shougo commented Apr 5, 2021

Powershell maintainer is needed...

@Shougo
Copy link
Contributor Author

Shougo commented Apr 5, 2021

Windows testers are needed.

install.sh Outdated
curl https://update.tabnine.com/bundles/$zip --create-dirs -o binaries/$zip
cd $(dirname binaries/$zip)
unzip -o TabNine.zip
chmod +x TabNine
Copy link

@dimacodota dimacodota Apr 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Shougo - you need to chmod all the executables in the directory

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WD-TabNine
TabNine
TabNine-deep-local
TabNine-deep-cloud

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and delete the zip file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Fixed.

@Shougo
Copy link
Contributor Author

Shougo commented Apr 5, 2021

Fixed.

@nekowasabi
Copy link

Worked by Windows gvim and Macbook Pro(2020).

@Shougo
Copy link
Contributor Author

Shougo commented Apr 8, 2021

Thanks!

@Shougo Shougo changed the title [WIP] Fix the update URIs [RFC] Fix the update URIs Apr 8, 2021
@Shougo
Copy link
Contributor Author

Shougo commented Apr 8, 2021

@tbodt Can you merge it? The current installation script is not compatible with the latest.

@tbodt
Copy link
Owner

tbodt commented Apr 8, 2021

Why would they change the download process... Thanks for fixing it.

@tbodt tbodt merged commit 181dc9e into tbodt:master Apr 8, 2021
@Shougo
Copy link
Contributor Author

Shougo commented Apr 8, 2021

Thanks!

Why would they change the download process... Thanks for fixing it.

They split the binary...

@Shougo Shougo deleted the update_script branch April 8, 2021 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants