Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change 5xx codes to 4xx for "get" methods ? #109

Closed
brobare opened this issue Oct 10, 2020 · 0 comments · Fixed by #111
Closed

Change 5xx codes to 4xx for "get" methods ? #109

brobare opened this issue Oct 10, 2020 · 0 comments · Fixed by #111

Comments

@brobare
Copy link
Contributor

brobare commented Oct 10, 2020

This issue is to request behavior changes on "get" routes that are currently returning 500 codes that might be better as 4xx.

For example, a "get" to /task/<task_id> if the task does not exist in redis returns a 500. An example:
https://github.com/tbotnz/netpalm/blob/master/netpalm/routers/task.py#L21

Might it be better to return something like a 404 if the task does not exist?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants