Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache interactions with Pre-Check and Post-Check are entirely unknown #64

Closed
wrgeorge1983 opened this issue Aug 17, 2020 · 2 comments
Closed

Comments

@wrgeorge1983
Copy link
Contributor

It's possible they already act as desired, or could be made that way quite easily. It's also possible it'll take some real digging into.

Since Checks are sort of "sub-tasks":

  • Do (or should) they require their own cache config?
  • Do (or should) they inherit the cache config of the parent task?
  • If the Parent is a setconfig call, it should ALWAYS invalidate any cache after a PreCheck and before a PostCheck.
Task Start -> Pre Check -> SetConfig -> Poison Cache -> Post Check
@wrgeorge1983
Copy link
Contributor Author

It's also possible anything involving pre/post checks should NEVER use the cache?

@tbotnz
Copy link
Owner

tbotnz commented Aug 17, 2020

Currently the pre & post checks are invoked as apart of the same job.
with the current code the following would behavior would occur.

  • if caching is applied on parent job, caching will apply to the pre & post checks
  • if no caching is applied on the parent job, no caching will apply to the pre & post checks

my thoughts on this are:

  • existing solution is simple and probably good enough
  • any attempts to change this would likely require refactoring the pre & post checks themselves

@tbotnz tbotnz closed this as completed Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants