Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bool attr parsing #243

Merged
merged 1 commit into from
Dec 18, 2021
Merged

Fix bool attr parsing #243

merged 1 commit into from
Dec 18, 2021

Conversation

tbranyen
Copy link
Owner

Fixes issue GH-242

Supports better parsing around attributes. Instead of simply mirroring keys like disabled to serve as the value, instead determine if a true value is more appropriate.

@tbranyen tbranyen mentioned this pull request Dec 17, 2021
Closed
@tbranyen
Copy link
Owner Author

tbranyen commented Dec 17, 2021 •
edited
Loading

Whoops this contains some other unrelated commits. Will move those out before merging.

@tbranyen tbranyen merged commit ee4c4ac into master Dec 18, 2021
@tbranyen tbranyen deleted the fix-bool-attr-parsing branch December 18, 2021 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tbranyen