Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about normative changes & deadline #1073

Merged
merged 5 commits into from
Apr 20, 2023
Merged

Add note about normative changes & deadline #1073

merged 5 commits into from
Apr 20, 2023

Conversation

ptomato
Copy link
Contributor

@ptomato ptomato commented Oct 22, 2021

See discussion in tc39/process-document#32 (comment)

This takes a "must" approach with PRs requiring consensus. If the outcome of the discussion is that PRs should be relaxed to a "should", I can revise this.

@ljharb
Copy link
Member

ljharb commented Oct 23, 2021

Converting to draft, pending plenary consensus.

template.md Outdated Show resolved Hide resolved
@ptomato
Copy link
Contributor Author

ptomato commented Jan 13, 2022

I've added this to the January agenda: #1104

@ptomato
Copy link
Contributor Author

ptomato commented Jan 24, 2022

I've added some language clarifying that the committee is expected to be more lenient with deadline exceptions for normative changes than for proposal stage advancements, to reflect what we talked about in the meeting. Let me know what you think!

cc @ljharb @erights @codehag @leobalter @syg

@ptomato ptomato marked this pull request as ready for review January 24, 2022 23:23
@ljharb ljharb self-assigned this Jan 25, 2022
Copy link
Contributor

@erights erights left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

template.md Outdated Show resolved Hide resolved
template.md Outdated Show resolved Hide resolved
Copy link
Contributor

@codehag codehag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few suggestions that are really nits. Looks good to me.

@ljharb ljharb force-pushed the ptomato-patch-1 branch 2 times, most recently from 105f5f5 to 6305956 Compare February 3, 2022 18:33
@ptomato
Copy link
Contributor Author

ptomato commented Feb 8, 2022

I rearranged the first bullet point as per @codehag's last suggestion, I think all the comments have been addressed now! Feel free to take a look.

template.md Outdated Show resolved Hide resolved
@ptomato ptomato requested a review from ljharb February 9, 2022 22:53
@ljharb
Copy link
Member

ljharb commented Feb 9, 2022

looks good still; i think this needs a few more reviews before landing tho, just in case :-)

template.md Outdated Show resolved Hide resolved
@ptomato
Copy link
Contributor Author

ptomato commented Feb 13, 2023

This dropped off my radar, as I actually thought it had already been merged. Could I get a few more reviews please?

@ctcpip ctcpip requested a review from robpalme March 6, 2023 18:02
template.md Outdated
1. Proposals looking to advance to stages 2, 3, or 4 must be added (and noted as such) *along with the necessary materials* prior to the deadline, or else delegates may object to advancement solely on the basis of missing the deadline.
1. Such proposals *must* link to supporting materials prior to the deadline, or else delegates may object to advancement solely on the basis of missing the deadline. If these materials change substantially after the deadline, the proposal may be disqualified from advancement, based on the committee’s judgment.
1. Proposals looking to advance to stages 2, 3, or 4, as well as other normative changes to the standard or proposals in stage 3 or later looking to achieve consensus, must be added (and noted as such) *along with links to the necessary materials* prior to the deadline, or else delegates may withhold consensus solely on the basis of missing the deadline.
1. If the supporting materials change substantially after the deadline, the proposal may be disqualified from advancement, based on the committee’s judgment.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may withhold consensus
may be disqualified from advancement

is there a substantive difference between these two? or should this language be normalized?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, missed the earlier ping. Looking back at the earlier revisions, I changed the above "object to advancement" to "withhold consensus" based on this comment.

The "may be disqualified from advancement, based on the committee's judgement" language is pre-existing, but on further reflection it's not really clear how that takes place — does the committee have to reach consensus on judging that the materials changed substantially? I think it makes sense to change something here, but changing it to something along the lines of "one delegate may withhold consensus if the materials change substantially" seems like it'd incentivize haggling over whether a change is "substantial" or not...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imo it's subjective, so it's up to each delegate. If an individual considers it substantial, it is.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • the may be disqualified language suggests there is some objective criteria that would disqualify something automatically.
  • agree with Jordan's comment
  • I think we should just normalize this language, as it amounts to the same thing, AFAICT

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolved via #1362 if we agree

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, works for me. I was concerned about opening up an avenue for abuse of the process, but that avenue was kind of already there.

ptomato and others added 5 commits April 20, 2023 12:10
Implement Yulia's suggestion of folding the part about linking to supporting materials before the deadline into the main point.
Co-authored-by: Jordan Harband <ljharb@gmail.com>
Implement Rob's suggestion for making the bullet point clearer.
@ctcpip ctcpip merged commit 81336d7 into main Apr 20, 2023
@ctcpip ctcpip deleted the ptomato-patch-1 branch April 20, 2023 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants