-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Normative] Make %TypedArray%.prototype.sort stable #1433
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
added
normative change
Affects behavior required to correctly evaluate some ECMAScript source text
needs consensus
This needs committee consensus before it can be eligible to be merged.
needs test262 tests
The proposal should specify how to test an implementation. Ideally via github.com/tc39/test262
labels
Jan 29, 2019
ljharb
approved these changes
Jan 29, 2019
zenparsing
approved these changes
Jan 29, 2019
ljharb
added
has consensus
This has committee consensus.
and removed
needs consensus
This needs committee consensus before it can be eligible to be merged.
labels
Jan 29, 2019
mathiasbynens
added a commit
to mathiasbynens/test262
that referenced
this pull request
Feb 2, 2019
mathiasbynens
added a commit
to mathiasbynens/test262
that referenced
this pull request
Feb 2, 2019
mathiasbynens
added a commit
to mathiasbynens/test262
that referenced
this pull request
Feb 2, 2019
mathiasbynens
added a commit
to mathiasbynens/test262
that referenced
this pull request
Feb 2, 2019
mathiasbynens
added a commit
to mathiasbynens/test262
that referenced
this pull request
Feb 2, 2019
mathiasbynens
added a commit
to mathiasbynens/test262
that referenced
this pull request
Feb 2, 2019
leobalter
pushed a commit
to tc39/test262
that referenced
this pull request
Feb 4, 2019
leobalter
added
has test262 tests
and removed
needs test262 tests
The proposal should specify how to test an implementation. Ideally via github.com/tc39/test262
labels
Feb 4, 2019
tests are now merged |
mathiasbynens
force-pushed
the
typedarray-sort
branch
from
February 5, 2019 07:44
cd23993
to
16e36e5
Compare
bterlson
approved these changes
Feb 5, 2019
Currently V8 [1] and SpiderMonkey [2] have unstable `%TypedArray%.prototype.sort` implementations. Both teams have publicly committed to making their implementations stable, to match `Array.prototype.sort` [3]. Test262 tests: tc39/test262#2062
ljharb
force-pushed
the
typedarray-sort
branch
from
February 6, 2019 23:19
16e36e5
to
a561c88
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
has consensus
This has committee consensus.
has test262 tests
normative change
Affects behavior required to correctly evaluate some ECMAScript source text
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently V8 [1] and SpiderMonkey [2] have unstable
%TypedArray%.prototype.sort
implementations. Both teams have publicly committed to making their implementations stable, to matchArray.prototype.sort
[3].Test262 tests: tc39/test262#2062
[1] https://bugs.chromium.org/p/v8/issues/detail?id=8567
[2] https://bugzilla.mozilla.org/show_bug.cgi?id=1290554
[3] #1340 (comment)