Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial: Simplify Promise.all and Promise.any #2219

Merged
merged 1 commit into from
Dec 7, 2020
Merged

Editorial: Simplify Promise.all and Promise.any #2219

merged 1 commit into from
Dec 7, 2020

Conversation

chicoxyzzy
Copy link
Member

@chicoxyzzy chicoxyzzy commented Oct 30, 2020 •
edited
Loading

[[AlreadyCalled]] fields in Promise.all and Promise.any doesn't have to be a Record

Discussion #2040 (comment)

@Jack-Works
Copy link
Member

It seems like Editorial not normative

mathiasbynens
mathiasbynens approved these changes Oct 30, 2020
View reviewed changes
Copy link
Member

@mathiasbynens mathiasbynens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I don't think this is a normative/observable change, in which case the commit message needs changing

shvaikalesh
shvaikalesh reviewed Oct 30, 2020
View reviewed changes
spec.html Outdated Show resolved Hide resolved
@chicoxyzzy chicoxyzzy force-pushed the promise_all_promise_any_simplification branch from 71dcc0c to ee71702 Compare October 30, 2020 10:20
@chicoxyzzy chicoxyzzy changed the title Normative: Simplify Promise.all and Promise.any Editorial: Simplify Promise.all and Promise.any Oct 30, 2020
shvaikalesh
shvaikalesh reviewed Oct 30, 2020
View reviewed changes
spec.html Outdated Show resolved Hide resolved
@ljharb ljharb requested review from michaelficarra, syg and a team November 29, 2020 06:19
@ljharb ljharb self-assigned this Nov 29, 2020
@michaelficarra michaelficarra added editor call to be discussed in the next editor call and removed editor call to be discussed in the next editor call labels Dec 1, 2020
@ljharb ljharb added the ready to merge Editors believe this PR needs no further reviews, and is ready to land. label Dec 2, 2020
@ljharb ljharb force-pushed the promise_all_promise_any_simplification branch from a42f54c to b3f9b50 Compare December 7, 2020 06:40
@ljharb ljharb merged commit b3f9b50 into tc39:master Dec 7, 2020
@chicoxyzzy chicoxyzzy deleted the promise_all_promise_any_simplification branch December 7, 2020 08:01
@ExE-Boss ExE-Boss mentioned this pull request Dec 13, 2020
Merged
1 task
doehyunbaek added a commit to doehyunbaek/ecma262 that referenced this pull request Jul 26, 2023
@doehyunbaek
Editorial: Change alreadyCalled from Record to Boolean
7c3d819 
PR tc39#2219 included changes to make > `[[AlreadyCalled]]` fields in
`Promise.all` and `Promise.any` from Record to boolean. It seems that
the changes were not reflected in AOs in sec-promise.allsettled. This
Commit fixes this.
@doehyunbaek doehyunbaek mentioned this pull request Jul 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shvaikalesh shvaikalesh shvaikalesh left review comments

@ljharb ljharb ljharb approved these changes

@mathiasbynens mathiasbynens mathiasbynens approved these changes

@syg syg syg approved these changes

@michaelficarra michaelficarra michaelficarra approved these changes

@bakkot bakkot bakkot approved these changes

Assignees

@ljharb ljharb

Labels
ready to merge Editors believe this PR needs no further reviews, and is ready to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@chicoxyzzy @Jack-Works @ljharb @mathiasbynens @syg @michaelficarra @bakkot @shvaikalesh