Meta: publish biblio to npm #2675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
reviewed
Feb 25, 2022
ljharb
reviewed
Mar 2, 2022
syg
approved these changes
Mar 2, 2022
bakkot
added
the
ready to merge
This comment was marked as outdated.
This comment was marked as outdated.
ljharb
force-pushed
the
publish-biblio
branch
2 times, most recently
from
c75e816
to
39ff7ce
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes tc39/ecmarkup#251. Fixes #2321.
I haven't tested this, but it will probably work.
Also, we need to pick a name for it.Edit: went withecma262-biblioseems like an obvious choice. We could choose to scope it under the@tc39namespace, but to my understanding we can have it be controlled by that organization even if we place it at the top-level scope.@tc39/ecma262-biblio.As for version numbers,
right now I'm just using the number of seconds since 1970 as the patch versionedit: went with number of commits on the branch, with an explicit callout in the readme that the package does not follow semver (since the biblio can change at any time, which can break your build if you depend on it for ecmarkup and build using--strict).