Editorial: OrdinaryCreateFromConstructor has wrong parameter type #3287
Conversation
dbarabashh
changed the title
|
@tutizaraz can you please confirm that you did not use a LLM (AI) for any part of this PR? |
|
@ljharb for english grammar only because it is not my native language |
ljharb
changed the title
spec.html
Outdated
| _intrinsicDefaultProto_: a String, | ||
| optional _internalSlotsList_: a List of names of internal slots, | ||
| ): either a normal completion containing an Object or a throw completion | ||
| </h1> | ||
| <dl class="header"> | ||
| <dt>description</dt> | ||
| <dd>It creates an ordinary object whose [[Prototype]] value is retrieved from a constructor's *"prototype"* property, if it exists. Otherwise the intrinsic named by _intrinsicDefaultProto_ is used for [[Prototype]]. _internalSlotsList_ contains the names of additional internal slots that must be defined as part of the object. If _internalSlotsList_ is not provided, a new empty List is used.</dd> | ||
| <dd>It creates an ordinary object whose [[Prototype]] value is retrieved from a function object's *"prototype"* property, if it exists. This object is referred to by _constructor_, which can be any function object. If the *"prototype"* property does not exist or _constructor_ is not a traditional constructor, the intrinsic named by _intrinsicDefaultProto_ is used for [[Prototype]]. _internalSlotsList_ contains the names of additional internal slots that must be defined as part of the object. If _internalSlotsList_ is not provided, a new empty List is used.</dd> |
There was a problem hiding this comment.
"traditional constructor" is not a defined term - either it's a constructor, or it isn't. This also isn't relevant here, the non-constructor cases do have a prototype property so intrinsicDefaultProto is not necessarily used for those.
There was a problem hiding this comment.
then do we need to revert the changes back to what it was?
There was a problem hiding this comment.
Yes, I think the original description is fine.
michaelficarra
added
the
ready to merge
michaelficarra
force-pushed
the
normative-update-OrdinaryCreateFromConstructor-first-arg-to-function-object
branch
from
8725a65
to
097a439
Compare
ljharb
force-pushed
the
normative-update-OrdinaryCreateFromConstructor-first-arg-to-function-object
branch
from
84b70ba
to
aada408
Compare
|
@tutizaraz would you please register as a contributor ? |
|
@dbarabashh please stop renaming your github account - every time you do you break our CI. (tutizaraz → riwom → dbarabashh, so far) |
|
@ljharb it was forced. username will not be changed anymore |
|
Not sure what could force it, but thanks, good to hear. |
Fixes #3168