Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normative: Allow CodeLike object evaluation #3294

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Commits on Apr 15, 2024

  1. Normative: Allow CodeLike object evaluation

    This change introduces a new HostDefinedIsCodeLike internal slot, this is used to allow evaluating certain objects.
    
    This change also provides the full code string,
    the compilation type and the original arguments, to the host hook HostEnsureCanCompileStrings.
    lukewarlow committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    7cb6b77 View commit details
    Browse the repository at this point in the history
  2. Changes based on consensus

    - Use a HostGetCodeForEval host hook rather than an internal slot.
    - Host hook returns a string or unknown and that string is what is evaluated not ToString.
    - Don't pass constructed codeString to HostEnsureCanCompileStrings
    lukewarlow committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    1c36fd0 View commit details
    Browse the repository at this point in the history
  3. Address comments

    - PerformEval _direct_ is now an enum.
    - Reordered steps for handling objects and strings in PerformEval.
    - Fixed usage of _x_ rather than _xStr_
    - Change new host hook to return String or ~no-code~
    lukewarlow committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    3c43358 View commit details
    Browse the repository at this point in the history
  4. Move HostEnsureCanCompileStrings back up to original position in Crea…

    …teDynamicFunction, it no longer needs moving as it doesn't need the source string.
    lukewarlow committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    77b9feb View commit details
    Browse the repository at this point in the history
  5. Fix

    lukewarlow committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    63dbfae View commit details
    Browse the repository at this point in the history

Commits on May 7, 2024

  1. Configuration menu
    Copy the full SHA
    21861c1 View commit details
    Browse the repository at this point in the history