Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider adding "microsecond" and "nanosecond" to the set of sanctioned unit identifiers #702

Closed
anba opened this issue Jul 26, 2022 · 2 comments
Closed

Consider adding "microsecond" and "nanosecond" to the set of sanctioned unit identifiers #702

anba opened this issue Jul 26, 2022 · 2 comments
Labels
c: numbers Component: numbers, currency, units new unit Request for a new unit in Intl.NumberFormat s: help wanted Status: help wanted; needs proposal champion Small Smaller change solvable in a Pull Request
Milestone
ES 2025

Comments

@anba
Copy link
Contributor

anba commented Jul 26, 2022

For Intl.DurationFormat we need to include the CLDR data for "microsecond" and "nanosecond" anyway, so we should consider adding both units to the set of sanctioned unit identifiers.
@sffc sffc added s: help wanted Status: help wanted; needs proposal champion Small Smaller change solvable in a Pull Request labels Jul 26, 2022
@sffc sffc added this to the ES 2023 milestone Jul 26, 2022
@anba anba mentioned this issue Aug 23, 2022
Closed
@anba anba mentioned this issue Aug 30, 2022
Merged
FrankYFTang added a commit that referenced this issue Aug 30, 2022
@FrankYFTang
Add "microsecond" and "nanosecond" to IsSanctionedSingleUnitIdentifier
0683d56 
Address #702 and needed by tc39/proposal-intl-duration-format#122
@FrankYFTang FrankYFTang mentioned this issue Aug 30, 2022
Merged
ryzokuken pushed a commit that referenced this issue Nov 3, 2022
@FrankYFTang @ryzokuken
Add "microsecond" and "nanosecond" to IsSanctionedSingleUnitIdentifier
f627573 
Address #702 and needed by tc39/proposal-intl-duration-format#122
@sffc sffc added c: numbers Component: numbers, currency, units new unit Request for a new unit in Intl.NumberFormat labels Mar 1, 2023
@ray007
Copy link

ray007 commented Apr 6, 2023

If SI unit prefixes were not part of the units, we'd not have this problem.

@FrankYFTang
Copy link
Contributor

This issue is fixed by #708 that merged in last Nov already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: numbers Component: numbers, currency, units new unit Request for a new unit in Intl.NumberFormat s: help wanted Status: help wanted; needs proposal champion Small Smaller change solvable in a Pull Request
Projects
None yet
Milestone
ES 2025
Development

No branches or pull requests
4 participants
@ray007 @sffc @anba @FrankYFTang