Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change url to https #464

Merged
merged 1 commit into from
Jun 22, 2020
Merged

Change url to https #464

merged 1 commit into from
Jun 22, 2020

Conversation

FrankYFTang
Copy link
Contributor

@FrankYFTang FrankYFTang commented Jun 20, 2020 •
edited
Loading

sffc
sffc reviewed Jun 22, 2020
View reviewed changes
Copy link
Contributor

@sffc sffc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it in theory, except the unicode.org SSL certificate has a bad track record for not being renewed on time, server going down, etc. @srl295, do you think HTTPS will be stable enough going forward to make this change?

@srl295
Copy link
Member

srl295 commented Jun 22, 2020

I like it in theory, except the unicode.org SSL certificate has a bad track record for not being renewed on time, server going down, etc. @srl295, do you think HTTPS will be stable enough going forward to make this change?

First of all, help is needed here. So let's lend a hand instead of hacking around it.
"not renewed on time" is old news. The https certificate is an autorenewed letsencrypt certificate, so it won't expire.

@leobalter leobalter merged commit b252de4 into tc39:master Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sffc sffc sffc left review comments

@leobalter leobalter leobalter approved these changes

@srl295 srl295 srl295 approved these changes

@littledan littledan Awaiting requested review from littledan

@zbraniecki zbraniecki Awaiting requested review from zbraniecki

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@FrankYFTang @srl295 @leobalter @sffc