-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support for labeling steps #74
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there some escape hatch that would allow us to write a step whose text begins with what looks like a label? It's not a big deal, but it would be nice.
Should we try to look for a label following an unordered list item so we can fail with a useful message instead of passing it through as text? |
Actually, now that I think about it, it could be useful to label an unordered list item. For example, linking to the step via a URL fragment. |
Sure, makes sense. Updated; want to take another look? |
In the ecma262 spec, I'm pretty sure there's no step-syntax currently in use that would allow a step to start with a left square bracket, so it's unclear what you'd need the escape hatch for. (In practice, the vast majority of steps start with an uppercase letter. The only exceptions I can find are:
) |
This introduces the ability to label steps, towards a solution to tc39/ecmarkup#192.
Corresponding upstream ecmarkup PR at tc39/ecmarkup#217. Corresponding upstream ecma262 PRs at tc39/ecma262#2052.
The ecmarkup PR describes how this is intended to be used, and the ecma262 PR shows what that looks like for ecma262 master.
Fixes #56.