Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notes + summaries for July 2023 #281

Merged
merged 1 commit into from
Sep 26, 2023
Merged

Add notes + summaries for July 2023 #281

merged 1 commit into from
Sep 26, 2023

Conversation

acutmore
Copy link
Contributor

@acutmore acutmore commented Sep 6, 2023

Like #268 but with updated summaries.

@ctcpip
Copy link
Member

ctcpip commented Sep 6, 2023

@littledan is this the Samina version referred to in #268 (comment) ?

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only reviewed the last commit; in general, please condense multiple spaces to 1, and we generally only use acronyms to refer to people in the notes.

meetings/2023-07/july-11.md Outdated Show resolved Hide resolved
meetings/2023-07/july-11.md Outdated Show resolved Hide resolved
meetings/2023-07/july-11.md Outdated Show resolved Hide resolved
meetings/2023-07/july-11.md Outdated Show resolved Hide resolved
meetings/2023-07/july-11.md Outdated Show resolved Hide resolved
meetings/2023-07/july-11.md Outdated Show resolved Hide resolved
meetings/2023-07/july-11.md Outdated Show resolved Hide resolved
meetings/2023-07/july-11.md Outdated Show resolved Hide resolved
meetings/2023-07/july-11.md Outdated Show resolved Hide resolved
@ctcpip
Copy link
Member

ctcpip commented Sep 6, 2023

condense multiple spaces to 1

might be able to take care of this via the lexer. I'll have a go

@ljharb
Copy link
Member

ljharb commented Sep 6, 2023

@ctcpip note that it shouldn't be condensed when it's indentation (start of line), or table spacing (like in the notes table)

@ctcpip
Copy link
Member

ctcpip commented Sep 6, 2023

@ctcpip note that it shouldn't be condensed when it's indentation (start of line), or table spacing (like in the notes table)

no worries, the existing test files should cover this. and the indentation at start of line shouldn't be where there is plain text (what the lexer detects as a paragraph), but can you provide an example of indentation that is expected? e.g. indenting a list wouldn't apply here

@ljharb
Copy link
Member

ljharb commented Sep 6, 2023

sounds like it'd be fine, just was making sure to call it out

@ctcpip
Copy link
Member

ctcpip commented Sep 6, 2023

sounds like it'd be fine, just was making sure to call it out

sure, just want to make sure we don't need to add anything to the test sample

@ctcpip
Copy link
Member

ctcpip commented Sep 6, 2023

might be able to take care of this via the lexer. I'll have a go

💥 #282 💥

@ctcpip
Copy link
Member

ctcpip commented Sep 7, 2023

https://github.com/acutmore/notes/pull/1/files

fixed 1408 extra whitespace character(s) in meetings/2023-07/july-13.md
fixed 1790 extra whitespace character(s) in meetings/2023-07/july-12.md
fixed 74 extra whitespace character(s) in meetings/2023-07/july-11.md

@ljharb
Copy link
Member

ljharb commented Sep 7, 2023

unfortunately since the summaries and notes are being landed together, i can't easily review just the formatted summaries :-/

@ctcpip
Copy link
Member

ctcpip commented Sep 7, 2023

I quickly skimmed the summaries/conclusions for problems but not substance... anyway, the whitespace should all be addressed and I fixed the non-TLA name references that appeared in conclusions/summaries

@acutmore
Copy link
Contributor Author

the whitespace should all be addressed and I fixed the non-TLA name references that appeared in conclusions/summaries

Thank you so much @ctcpip !

@ctcpip

This comment was marked as resolved.

@ctcpip ctcpip merged commit afc1eac into tc39:main Sep 26, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants