Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Editorial] Fix typo and improve descriptions. #22

Merged
merged 2 commits into from
Apr 20, 2021
Merged

Conversation

FrankYFTang
Copy link
Collaborator

No description provided.

Copy link
Contributor

@sffc sffc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one comment

@@ -490,8 +490,9 @@ <h1><ins>get Intl.Locale.prototype.timeZones</ins></h1>
<emu-alg>
1. <ins>Let _loc_ be the *this* value.</ins>
1. <ins>Perform ? RequireInternalSlot(_loc_, [[InitializedLocale]]).</ins>
1. <ins>Let _locale_ be _loc_.[[Locale]].</ins>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra line?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this is needed in this timeZones function because the next line need it.

@FrankYFTang FrankYFTang merged commit 3edf925 into main Apr 20, 2021
@FrankYFTang FrankYFTang deleted the addressSffc branch April 20, 2021 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants