Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should segment data objects expose the context string? #116

Closed
gibson042 opened this issue Jun 4, 2020 · 1 comment · Fixed by #117
Closed

Should segment data objects expose the context string? #116

gibson042 opened this issue Jun 4, 2020 · 1 comment · Fixed by #117
Labels
stage 3 blocker

Comments

@gibson042
Copy link
Collaborator

gibson042 commented Jun 4, 2020 •
edited
Loading

Segment Iterator objects are analogous to RegExp String Iterator objects, whose iteration results are RegExp matches (i.e., { 0: matchedSubstring, 1: capture1, …, index, input, groups }). Segment data objects currently have segment (analogous to 0), index (analogous to index), and isWordLike (analogous to captures), but are missing input.
gibson042 added a commit to gibson042/proposal-intl-segmenter that referenced this issue Jun 4, 2020
@gibson042
Normative: Add "input" to segment data objects
5fdbc11 
Improves correspondence with RegExp match objects

Fixes tc39#116
@gibson042 gibson042 mentioned this issue Jun 4, 2020
Merged
@gibson042 gibson042 mentioned this issue Jul 9, 2020
Closed
@gibson042
Copy link
Collaborator Author

Resolved in today's ECMA-402 call to move forward with this.

gibson042 added a commit that referenced this issue Jul 10, 2020
@gibson042
Normative: Move input string access from %SegmentsPrototype% to segme…
2e838dd 
…nt data objects

Improves correspondence with RegExp match objects
* Normative: Remove `string` accessor from %SegmentsPrototype%
* Normative: Add "input" to segment data objects

Fixes #116
Fixes #96
Closes #117
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stage 3 blocker
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Normative: Add "input" to segment data objects gibson042/proposal-intl-segmenter
1 participant
@gibson042