Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add lb option #22

Closed
littledan opened this issue Jan 20, 2018 · 0 comments · Fixed by #24
Closed

Add lb option #22

littledan opened this issue Jan 20, 2018 · 0 comments · Fixed by #24

Comments

@littledan
Copy link
Member

The lb Unicode extension key is equivalent to the "strictness" option. In the spirit of parity between options and tags, we should add support for this key to the segmenter.
littledan added a commit that referenced this issue Jan 21, 2018
@littledan
Normative: Provide line break mode in Unicode extension key
8ad91e4 
This patch allows Intl.Segmenter to have the line break mode set by
the Unicode extension key "lb", in addition to the "strictness"
entry in the options bag.

Drive-by fixes:
- Switch default options to be based on a null prototype, similar
  to other Intl constructors.
- Use backticks for string literals

Closes #22
@littledan littledan mentioned this issue Jan 21, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Normative: Provide line break mode in Unicode extension key tc39/proposal-intl-segmenter
1 participant
@littledan