Editorial: Limit year, month, and week length calculations to nonzero

ptomato · ptomato · commit ed85e96910c2 · 2023-11-16T11:15:16.000-08:00
In order to calculate the rounded value and totals in RoundDuration, when rounding to years, months, or weeks, we need to divide by the length of the year, month, or week in days. Throw an exception if this would otherwise result in division by zero. This is marked 'editorial' because division by zero with mathematical values is an editorial error in the spec. However, the month/week divisions didn't exist before the normative change in the previous commit, so this would previously only have applied to years. Closes: #2335
diff --git a/polyfill/lib/ecmascript.mjs b/polyfill/lib/ecmascript.mjs
@@ -5690,6 +5690,7 @@ export function RoundDuration(
       // the duration. This lets us do days-or-larger rounding using BigInt
       // math which reduces precision loss.
       oneYearDays = MathAbs(oneYearDays);
+      if (oneYearDays === 0) throw new RangeError('custom calendar reported that a year is 0 days long');
       const divisor = bigInt(oneYearDays).multiply(dayLengthNs);
       nanoseconds = divisor.multiply(years).plus(bigInt(days).multiply(dayLengthNs)).plus(nanoseconds);
       const rounded = RoundNumberToIncrement(nanoseconds, divisor.multiply(increment).toJSNumber(), roundingMode);
@@ -5737,6 +5738,7 @@ export function RoundDuration(
       let { days: oneMonthDays } = MoveRelativeDate(calendarRec, plainRelativeTo, oneMonth);
 
       oneMonthDays = MathAbs(oneMonthDays);
+      if (oneMonthDays === 0) throw new RangeError('custom calendar reported that a month is 0 days long');
       const divisor = bigInt(oneMonthDays).multiply(dayLengthNs);
       nanoseconds = divisor.multiply(months).plus(bigInt(days).multiply(dayLengthNs)).plus(nanoseconds);
       const rounded = RoundNumberToIncrement(nanoseconds, divisor.multiply(increment), roundingMode);
@@ -5774,6 +5776,7 @@ export function RoundDuration(
       let { days: oneWeekDays } = MoveRelativeDate(calendarRec, plainRelativeTo, oneWeek);
 
       oneWeekDays = MathAbs(oneWeekDays);
+      if (oneWeekDays === 0) throw new RangeError('custom calendar reported that a week is 0 days long');
       const divisor = bigInt(oneWeekDays).multiply(dayLengthNs);
       nanoseconds = divisor.multiply(weeks).plus(bigInt(days).multiply(dayLengthNs)).plus(nanoseconds);
       const rounded = RoundNumberToIncrement(nanoseconds, divisor.multiply(increment), roundingMode);
diff --git a/spec/duration.html b/spec/duration.html
@@ -1716,6 +1716,7 @@ <h1>
           1. Let _oneYear_ be ! CreateTemporalDuration(_sign_, 0, 0, 0, 0, 0, 0, 0, 0, 0).
           1. Set _moveResult_ to ? MoveRelativeDate(_calendarRec_, _plainRelativeTo_, _oneYear_).
           1. Let _oneYearDays_ be _moveResult_.[[Days]].
+          1. If _oneYearDays_ = 0, throw a *RangeError* exception.
           1. Let _fractionalYears_ be _years_ + _fractionalDays_ / abs(_oneYearDays_).
           1. Set _years_ to RoundNumberToIncrement(_fractionalYears_, _increment_, _roundingMode_).
           1. Set _total_ to _fractionalYears_.
@@ -1744,6 +1745,7 @@ <h1>
           1. Let _oneMonth_ be ! CreateTemporalDuration(0, _sign_, 0, 0, 0, 0, 0, 0, 0, 0).
           1. Let _moveResult_ be ? MoveRelativeDate(_calendarRec_, _plainRelativeTo_, _oneMonth_).
           1. Let _oneMonthDays_ be _moveResult_.[[Days]].
+          1. If _oneMonthDays_ = 0, throw a *RangeError* exception.
           1. Let _fractionalMonths_ be _months_ + _fractionalDays_ / abs(_oneMonthDays_).
           1. Set _months_ to RoundNumberToIncrement(_fractionalMonths_, _increment_, _roundingMode_).
           1. Set _total_ to _fractionalMonths_.
@@ -1765,6 +1767,7 @@ <h1>
           1. Let _oneWeek_ be ! CreateTemporalDuration(0, 0, _sign_, 0, 0, 0, 0, 0, 0, 0).
           1. Let _moveResult_ be ? MoveRelativeDate(_calendarRec_, _plainRelativeTo_, _oneWeek_).
           1. Let _oneWeekDays_ be _moveResult_.[[Days]].
+          1. If _oneWeekDays_ = 0, throw a *RangeError* exception.
           1. Let _fractionalWeeks_ be _weeks_ + _fractionalDays_ / abs(_oneWeekDays_).
           1. Set _weeks_ to RoundNumberToIncrement(_fractionalWeeks_, _increment_, _roundingMode_).
           1. Set _total_ to _fractionalWeeks_.
