-
Notifications
You must be signed in to change notification settings - Fork 717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update test262 status #431
Conversation
ptomato
commented
Sep 13, 2022
- Array-grouping tests are under review
- RegExp v flag tests have been merged
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can not group an Array
This comment was marked as off-topic.
This comment was marked as off-topic.
@@ -142,6 +142,7 @@ Note that as part of the onboarding process your repository name may be normaliz | |||
[symbols-weakmap]: https://github.com/tc39/proposal-symbols-as-weakmap-keys | |||
[symbols-weakmap-notes]: https://github.com/tc39/notes/blob/HEAD/meetings/2022-06/jun-07.md#symbols-as-weakmap-keys | |||
[regexp-v-flag]: https://github.com/tc39/proposal-regexp-v-flag | |||
[regexp-v-flag-tests]: https://github.com/tc39/test262/pull/3523 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those are just some of the tests. Here’s the other 2 PRs: tc39/test262#3496 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be a tedious exercise to list all of the test262 PRs for every proposal; maybe we should make the checkmarks link into the test262 tree instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests are not always all in the same directory, as is the case here. Maybe the thing to do is to refer to the feature tag as used in the frontmatter for the tests, as registered in https://github.com/tc39/test262/blob/main/features.txt? For this particular feature that’d be regexp-v-flag
.
Alternatively, we could just point to the Test262 tracking issue, or in this case, the issue comment I linked to in my earlier comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the idea of using the feature flag
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have a look at #432...