-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scopes: Update kind
to be an arbitrary string in the names
field
#107
Conversation
Some suggestion of standard name fields may still be useful here for clients, e.g. in types saying |
I updated to add these as suggested names. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Latest change looks good to me, I do like having the suggestions there.
Should the |
Absolute vs. relative offsets for If a generator adds a If a generator is able to preload all names for If a generator is able to preload all names for In the meeting, I was under the mistaken impression that a relative |
The spec PR tc39/source-map#107 changed the original scope kind to be an index into the names array given that 'global', 'function', etc. might not be applicable to every authored language. This CL aligns the DevTools implementation with the latest spec. R=pfaffe@chromium.org Bug: 40277685 Change-Id: Id4b9915aaab6138fbf2dae5eaf48c6e52b999b40 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5724710 Reviewed-by: Philip Pfaffe <pfaffe@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org>
This changes
kind
from an enum of known values, to be an index into thenames
field holding any arbitrary string. This allows us to better accommodate non-JS languages.