Scopes: Make the offsets into the names array absolute #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jridgewell
approved these changes
Apr 25, 2024
| @@ -206,11 +206,10 @@ Note: Each DATA represents one VLQ number. | |||
| * 0x1 has name | |||
| * name: (only exists if `has name` flag is set) | |||
| * DATA offset into `names` field | |||
There was a problem hiding this comment.
Should we clarify that these are absolute offsets?
There was a problem hiding this comment.
I think it's clear enough that offsets are absolute if they're not explicitly specified to be relative. Anyway this will most likely change when we decide on #70 .
szuend
approved these changes
Apr 26, 2024
github-actions bot
added a commit
that referenced
this pull request
Apr 26, 2024
SHA: f23f788 Reason: push, by hbenl Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
to szuend/source-map
that referenced
this pull request
May 21, 2024
SHA: f23f788 Reason: push, by szuend Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the last meeting we decided to make the offsets into the names array absolute for now until we have decided how to deal with #70 .
@jridgewell I also wanted to add you as a reviewer but for some reason Github won't let me.