Basic tests for BigInt #1198
Merged
Basic tests for BigInt #1198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merging this will allow me to follow with more coverage in the same parts that are not complete yet. |
Closed
anba
reviewed
Sep 5, 2017
| assert.sameValue(0 >= 0n, true); | ||
| assert.sameValue(0n >= 0, true); | ||
| assert.sameValue(1n >= Number.MAX_VALUE, false); | ||
| assert.sameValue(Number.MIN_VALUE >= 0n, false); |
There was a problem hiding this comment.
I don't understand why the expected value for this case should be false (also applies to the other comparison operators tests with Number.MIN_VALUE). Number.MIN_VALUE is positive, non-zero number, so shouldn't this comparison return true?
There was a problem hiding this comment.
You're right, I missed this assertion when updating the assertions from the similar <= file.
leobalter
added a commit
to leobalter/test262
that referenced
this pull request
Sep 5, 2017
rwaldron
pushed a commit
that referenced
this pull request
Sep 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is only a refactor of tests from #1148. I'm not trying neither willing to add coverage in this PR.