Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test update for proposed Annex B.3.5 simplification #2023

Merged
merged 4 commits into from
Jan 30, 2019

Conversation

rkirsling
Copy link
Member

This PR updates tests for tc39/ecma262#1393.

leobalter
leobalter previously approved these changes Jan 7, 2019
Copy link
Member

@leobalter leobalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests are correct and LGTM. I just got two nit picks with comments above.

Looking forward to get this approved.

@ljharb
Copy link
Member

ljharb commented Jan 29, 2019

tc39/ecma262#1393 has achieved consensus; it'd be great to merge these tests so we can update the labels there :-)

Copy link
Member

@mathiasbynens mathiasbynens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this test needs to be updated/deleted as well: test/language/statements/try/early-catch-var.js

@rkirsling
Copy link
Member Author

Thanks for catching that!

Copy link
Contributor

@rwaldron rwaldron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes and new test material!

@rwaldron rwaldron merged commit afe1b5a into tc39:master Jan 30, 2019
@rkirsling rkirsling deleted the simplify-annex-b.3.5 branch January 30, 2019 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants