-
Notifications
You must be signed in to change notification settings - Fork 461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test update for proposed Annex B.3.5 simplification #2023
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests are correct and LGTM. I just got two nit picks with comments above.
Looking forward to get this approved.
test/annexB/language/statements/try/catch-redeclared-for-of-var.js
Outdated
Show resolved
Hide resolved
test/annexB/language/statements/try/catch-redeclared-for-of-var.js
Outdated
Show resolved
Hide resolved
test/annexB/language/statements/try/catch-redeclared-for-of-var.js
Outdated
Show resolved
Hide resolved
tc39/ecma262#1393 has achieved consensus; it'd be great to merge these tests so we can update the labels there :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this test needs to be updated/deleted as well: test/language/statements/try/early-catch-var.js
Thanks for catching that! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fixes and new test material!
This PR updates tests for tc39/ecma262#1393.