Set function length and name in CreateBuiltinFunction
#2921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
ExE-Boss
force-pushed
the
normative/built-ins/set-name-and-length-in-create-builtin-function
branch
2 times, most recently
from
0c77c4b
to
ed023e8
Compare
|
@ExE-Boss I'd like to wait until at least one from your requested "cc" list responds with an approval, otherwise this looks good to me. |
bakkot
reviewed
Dec 26, 2020
1 task
rwaldron
requested changes
Jan 28, 2021
ExE-Boss
force-pushed
the
normative/built-ins/set-name-and-length-in-create-builtin-function
branch
from
b5b6d6e
to
7fc0484
Compare
rwaldron
approved these changes
Jan 29, 2021
ExE-Boss
deleted the
normative/built-ins/set-name-and-length-in-create-builtin-function
branch
webkit-commit-queue
pushed a commit
to WebKit/WebKit
that referenced
this pull request
Jan 30, 2021
https://bugs.webkit.org/show_bug.cgi?id=221168 Reviewed by Darin Adler. JSTests: * stress/host-function-property-order.js: Added. (shouldBe): Source/JavaScriptCore: We should first define "length" before "name". This will be included in upcoming test262 update[1]. [1]: tc39/test262#2921 * runtime/JSFunction.cpp: (JSC::JSFunction::finishCreation): Canonical link: https://commits.webkit.org/233508@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@272099 268f45cc-cd09-0410-ab3c-d52691b4dbfc
bertogg
pushed a commit
to Igalia/webkit
that referenced
this pull request
Feb 1, 2021
https://bugs.webkit.org/show_bug.cgi?id=221168 Reviewed by Darin Adler. JSTests: * stress/host-function-property-order.js: Added. (shouldBe): Source/JavaScriptCore: We should first define "length" before "name". This will be included in upcoming test262 update[1]. [1]: tc39/test262#2921 * runtime/JSFunction.cpp: (JSC::JSFunction::finishCreation): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@272099 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spec: tc39/ecma262#2116
I’ve also added tests for all built‑in functions that had their tests updated in #2299.
/cc @bakkot @ljharb @michaelficarra @syg