Add tests for JSON modules #2999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jugglinmike
added a commit
to bocoup/test262-stream
that referenced
this pull request
May 28, 2021
A change in Test262's interpreting guidelines was proposed via the following patch: tc39/test262#2999
jugglinmike
added a commit
to bocoup/test262-stream
that referenced
this pull request
May 28, 2021
A change in Test262's interpreting guidelines was proposed via the following patch: tc39/test262#2999 Accomodating this change does not interfere with test262-stream's compatability with prior versions of Test262 because none of the tests present in prior versions used the sequence `_FIXTURE` in file names for anything other than fixture files.
rwaldron
requested changes
May 28, 2021
rwaldron
pushed a commit
to bocoup/test262-stream
that referenced
this pull request
May 28, 2021
A change in Test262's interpreting guidelines was proposed via the following patch: tc39/test262#2999 Accomodating this change does not interfere with test262-stream's compatability with prior versions of Test262 because none of the tests present in prior versions used the sequence `_FIXTURE` in file names for anything other than fixture files.
This change is in service of forthcoming tests for the "JSON modules" language proposal [1]. Verifying the semantics of that proposal requires modules whose source text is not valid ECMAScript; this change updates the guidelines for contributing and interpreting tests so that such test material can be handled consistently. Differentiating JSON files with a distinct file name suffice will assist consumers which require special handling of such files (e.g. web browsers). Change the pattern used to designate "fixture" files so that it may be applied to files used for JSON modules. Increment the project version number to alert consumers of this change in interpreting instructions. [1] https://github.com/tc39/proposal-json-modules
https://github.com/tc39/proposal-json-modules This proposal advanced to Stage 3 of TC39's standardization process on 2021-01-27.
|
Got it Rick. I've split the infrastructural changes into a dedicated commit which precedes the commit introducing the "JSON modules" tests. |
rwaldron
approved these changes
May 29, 2021
This comment was marked as spam.
This comment was marked as spam.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Designate the files which are intended to be interpreted as JSON modules
via a distinct file name suffix. Differentiating JSON files in this way
will assist consumers which require special handling of such files (e.g.
web browsers).
Change the pattern used to designate "fixture" files so that it may be
applied to files used for JSON modules.
Increment the project version number to alert consumers of this change
in interpreting instructions.