Add tests for proposal array find from last #3045
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
rwaldron
requested changes
Jul 16, 2021
There was a problem hiding this comment.
Please add to features.txt:
# Array.prototype.findLast & Array.prototype.findLastIndex
# https://github.com/tc39/proposal-array-find-from-last
array-find-from-last
Add to meta data in all files:
features: [array-find-from-last]
Fix all license headers to read:
// Copyright (C) 2021 Microsoft. All rights reserved.
test/built-ins/Array/prototype/findLast/array-altered-during-loop.js
Outdated
Show resolved
Hide resolved
test/built-ins/Array/prototype/findLast/array-altered-during-loop.js
Outdated
Show resolved
Hide resolved
|
Thanks for the updates. I will review this week |
jugglinmike
requested changes
Jul 19, 2021
test/built-ins/Array/prototype/findLast/array-altered-during-loop.js
Outdated
Show resolved
Hide resolved
test/built-ins/Array/prototype/findLast/predicate-call-this-strict.js
Outdated
Show resolved
Hide resolved
test/built-ins/Array/prototype/findLast/return-found-value-predicate-result-is-true.js
Outdated
Show resolved
Hide resolved
|
Thanks for the review. |
rwaldron
previously approved these changes
Jul 20, 2021
|
Once @jugglinmike give this R+, it's good to go. |
jugglinmike
previously requested changes
Jul 26, 2021
test/built-ins/Array/prototype/findLast/array-altered-during-loop.js
Outdated
Show resolved
Hide resolved
test/built-ins/Array/prototype/findLastIndex/array-altered-during-loop.js
Outdated
Show resolved
Hide resolved
test/built-ins/TypedArray/prototype/findLast/BigInt/predicate-call-changes-value.js
Outdated
Show resolved
Hide resolved
test/built-ins/TypedArray/prototype/findLast/BigInt/predicate-call-changes-value.js
Outdated
Show resolved
Hide resolved
test/built-ins/TypedArray/prototype/findLast/predicate-call-changes-value.js
Outdated
Show resolved
Hide resolved
test/built-ins/TypedArray/prototype/findLast/predicate-call-changes-value.js
Outdated
Show resolved
Hide resolved
test/built-ins/TypedArray/prototype/findLastIndex/BigInt/predicate-call-changes-value.js
Outdated
Show resolved
Hide resolved
test/built-ins/TypedArray/prototype/findLastIndex/predicate-call-changes-value.js
Outdated
Show resolved
Hide resolved
|
Sorry. I have missed these case. |
rwaldron
approved these changes
Jul 28, 2021
|
Manually merged |
|
Thanks! |
jugglinmike
added a commit
that referenced
this pull request
Jul 31, 2021
The tests for the "Array findFromLast" proposal were originally authored based on related tests that had already been merged to the repository's `main` branch [1]. While those new tests were under review, a number of tests for the Resizable ArrayBuffer proposal were found to be incorrect [2]. The problem was fixed for the tests in `main`, but because the corresponding tests for "Array findFromLast" were not yet merged, the error persisted there [3]. Apply the same correction to the new tests. [1] #3111 [2] #3113 [3] #3045
|
I had some time today, so I wrote that patch: gh-3126 |
rwaldron
pushed a commit
that referenced
this pull request
Aug 2, 2021
The tests for the "Array findFromLast" proposal were originally authored based on related tests that had already been merged to the repository's `main` branch [1]. While those new tests were under review, a number of tests for the Resizable ArrayBuffer proposal were found to be incorrect [2]. The problem was fixed for the tests in `main`, but because the corresponding tests for "Array findFromLast" were not yet merged, the error persisted there [3]. Apply the same correction to the new tests. [1] #3111 [2] #3113 [3] #3045
rwaldron
pushed a commit
that referenced
this pull request
Aug 10, 2021
The tests for the "Array findFromLast" proposal were originally authored based on related tests that had already been merged to the repository's `main` branch [1]. While those new tests were under review, a number of tests for the Resizable ArrayBuffer proposal were found to be incorrect [2]. The problem was fixed for the tests in `main`, but because the corresponding tests for "Array findFromLast" were not yet merged, the error persisted there [3]. Apply the same correction to the new tests. [1] #3111 [2] #3113 [3] #3045
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This proposal is currently at "stage 3".