Normative: Add new numbering system "tnsa" #3572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptomato
reviewed
Jun 20, 2022
Add NS digit mappings
ptomato
reviewed
Jun 21, 2022
thks Co-authored-by: Philip Chimento <philip.chimento@gmail.com>
ptomato
approved these changes
Jun 21, 2022
There was a problem hiding this comment.
This seems correct to me.
I'm not sure if there are any other places where we'd have to edit a table, or something. I'll check with the other maintainers, then merge it.
I see number formats in implementation-contributed/v8/intl/{date,number}-format/check-nu-option.js but I understand our current policy is not to update the tests in implementation-contributed/ unless the implementations themselves do it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add new numbering system "tnsa" to tests
Supporting details
https://github.com/unicode-org/cldr/blob/main/common/bcp47/number.xml#L95
Related issues
tc39/ecma402#614