Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RAB: Integrate staging tests for the .entries method #4073

Merged
merged 4 commits into from
Jun 26, 2024

Commits on Jun 26, 2024

  1. RAB: Integrate staging tests for the .entries method

    of Array.prototype and TypedArray.prototype
    
    This is part of PR tc39#3888 to make reviewing easier.
    Includes changes to use the helper ./harness/resizableArrayBufferUtils.js
    ioannad authored and ptomato committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    6854997 View commit details
    Browse the repository at this point in the history
  2. Added missing includes

    ioannad authored and ptomato committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    3d953f2 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    efa60b3 View commit details
    Browse the repository at this point in the history
  4. Addressed review comments

    - Add assertion messages when the error message will not be otherwise obvious.
      https://github.com/tc39/test262/pull/4073/files#r1597294649
    - Also addressed a relevant comment from the .copyWithin review, removing obfuscating uses of a helper function.
      https://github.com/tc39/test262/pull/4072/files#r1594455691
    ioannad authored and ptomato committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    a75dda0 View commit details
    Browse the repository at this point in the history