Improvements #14
Merged
Improvements #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So we could use the output for other things than writing it out
To prevent nil pointer dereference when running multiple tests in a row
Improvement: Make source port value parameter
…+ rename port to ReceiverPort to be RFC complient
tcaine
approved these changes
Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
First of all, thanks for your work! It was a great base for my work!
Content
I found number of TODOs in the code to make it work. I fixed them. Please check commits for details but in a nutshell:
IP Versionfield was filled with zero in theRequest Sessionmessage. It can be 4 or 6 only.TwampSessionConfigstruct is now easier to understand regarding the ports and a hardcoded part number is also replaced to use this config struct instead.Backlog
It would be still nice to refactor the TWAMP control channel massaging to use golang struct types instead of math with byte offsets same way as I implemented with the actual measurement message types.