Fix for issue14: https://github.com/tcalmant/ipopo/issues/95 #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcalmant
requested changes
Apr 26, 2018
pelix/framework.py
Outdated
| # Normalize the UID: it must be a string | ||
| self.__properties[FRAMEWORK_UID] = str(framework_uid) | ||
| self.__properties[FRAMEWORK_UID] = framework_uid |
There was a problem hiding this comment.
framework_uid should be converted to str before this line, to ensure that line 629 didn't return something else (like an integer or UUID object).
This would remove the need to call str() on line 631, and ensure the type on a single line
|
Added string normalization. |
tcalmant
approved these changes
Apr 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue14...support standard property name for framework.uid of 'org.osgi.framework.uuid'