-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Composite types #57
Conversation
Hoverbear
commented
Jul 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
src/lib.rs
Outdated
Some(String::from_utf8(output.stdout.clone()).expect("`cargo`'s stdout was not UTF-8")), | ||
Some(String::from_utf8(output.stderr.clone()).expect("`cargo`'s stderr was not UTF-8")), | ||
Some( | ||
String::from_utf8(output.stdout.clone()).expect("`cargo`'s stdout was not UTF-8"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: extra space before UTF-8
src/lib.rs
Outdated
String::from_utf8(output.stdout.clone()).expect("`cargo`'s stdout was not UTF-8"), | ||
), | ||
Some( | ||
String::from_utf8(output.stderr.clone()).expect("`cargo`'s stderr was not UTF-8"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
Should probably look into the CI failures, eh? |
Signed-off-by: Ana Hobden <operator@hoverbear.org>
let composite_type_oid: u32 = unsafe { | ||
let mut typoid = 0; | ||
let mut typmod = 0; | ||
pg_sys::parseTypeString("Dog".as_pg_cstr(), &mut typoid, &mut typmod, false); | ||
typoid | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to find a way to wrap this outside this function before this is acceptable.