Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Blacklisting also #13

Closed
shahidmau opened this issue Jan 22, 2020 · 1 comment
Closed

Allow Blacklisting also #13

shahidmau opened this issue Jan 22, 2020 · 1 comment

Comments

@shahidmau
Copy link

Is there any way to allow blacklisting instead of whitelisting, so we will mention the fields name to be masked and remaining fields will not be masked.

@sergiv83
Copy link

sergiv83 commented Apr 1, 2020

@shahidmau We thought about this feature and decided to not add it to the lib. It's potentially dangerous. In the case of typo or misconfiguration with the whitelisting approach, you'll have the field masked and will not see the original value. In contrast to that with the blacklisting approach, the value can appear unmasked. It can bring lots of problems. For example, we stored our logs to the 3-rd party service for aggregation and had to be sure that customer PI information will not appear unmasked in these logs for any case.

@sergiv83 sergiv83 closed this as completed Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants