Addresed #69: Refactored and added crud ops to course model #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…js (previously student.js)
Hitansh159
suggested changes
Jul 2, 2023
models/course.js
Outdated
| theoryHours: { type: Number, required: true }, | ||
| tutorialHours: { type: Number, required: true }, | ||
| practicalHours: { type: Number, required: true }, | ||
| totalHours: { // virtual to return total hours based on th + tut + prac hrs |
There was a problem hiding this comment.
refer to this for creating virtual attribute
https://mongoosejs.com/docs/tutorials/virtuals.html#virtuals-via-schema-options
models/course.js
Outdated
| evalScheme: { type: [Number], required: true }, | ||
| }; | ||
|
|
||
| // eslint-disable-next-line no-unused-vars |
There was a problem hiding this comment.
For CURD refer models/user.js
use filters for genric behaviour
Hitansh159
approved these changes
Jul 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Renamed student model to course, refactored and implemented CRUD to course model
Fixes
Fixed #69 as mentioned in the issue.
Checklist