Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add faculty model #55

Closed
wants to merge 1 commit into from

Conversation

sumitshinde-84
Copy link
Contributor

@sumitshinde-84 sumitshinde-84 commented Jun 12, 2023

  • The code includes a custom databaseUtil module for handling the database connection.
  • The Faculty model is created using the model method provided by the connector object from the databaseUtil module.
  • The Faculty model is exported for use in other parts of the application.
    closes create faculty model #39

@TejasNair9977
Copy link
Member

TejasNair9977 commented Jun 13, 2023

Alright, @sumitshinde-84, the structure itself is perfect, if it's possible, I'd like you to add a few attributes so I can accept this.

empType: str #among admin, management, faculty, etc.
emdUID: str
preferredSubjects: Subjects[]
# assume this object exists
profileLink: URL
designation: str[] # HOD and professor are different roles which one person can have at the same time TCET Faculty Page
natureOfAssociation: str
uniApprovalStatus: str
qualifications: str[]
totalExperience: str # just how long theyve been teaching/working including other colleges
additionalResponsibilities: str # refer above doc ig
department: Department # this will be different than a string, its a model which will exist in the base model folder, though it doesnt already exist. it will be called department.js and will contain the model for department
achievements: Array(str)
areaOfSpecialization: Array(str)
papersPublishedPG: int
papersPublishedUG: int

There may be an attribute or two in here which are redundant, but all of them are necessary. Here, the designation, and in your PR, the position attribute is the same. Other than that, just add these attributes, and we can accept it.

Copy link
Member

@TejasNair9977 TejasNair9977 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After the above changes, we can accept the PR.

@TejasNair9977
Copy link
Member

TejasNair9977 commented Jun 13, 2023

Also, I mentioned a new Subjects object in the above message. It doesn't exist, since someone else is working on it right now, but it will be in the base folder in models under the name subject.js, with the object name as Subject. This Faculty object will contain multiple of these Subject objects. Please tell me if you need clarification on anything.

@TejasNair9977
Copy link
Member

Also, I just noticed, but please fork from and make a PR to the development branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create faculty model
2 participants