Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Change remaining blob columns to text #111

Merged
merged 1 commit into from
Nov 4, 2023
Merged

Fix: Change remaining blob columns to text #111

merged 1 commit into from
Nov 4, 2023

Conversation

tchapi
Copy link
Owner

@tchapi tchapi commented Oct 7, 2023

Following #110

@tchapi tchapi mentioned this pull request Oct 7, 2023
Closed
@tchapi tchapi marked this pull request as ready for review October 16, 2023 07:25
@tchapi tchapi mentioned this pull request Nov 1, 2023
Closed
@tchapi tchapi self-assigned this Nov 4, 2023
@tchapi tchapi merged commit 3d2f758 into master Nov 4, 2023
15 checks passed
@tchapi tchapi deleted the fix/blob-columns branch November 4, 2023 13:11
@de-es
Copy link

de-es commented Dec 23, 2023

Unfortunately is using TEXT in carddata from the cards table insufficient for my data. I got some images exceeding the TEXT with Data too long.

@tchapi
Copy link
Owner Author

tchapi commented Dec 29, 2023

Unfortunately is using TEXT in carddata from the cards table insufficient for my data. I got some images exceeding the TEXT with Data too long.

Ah, interesting point.TEXT on Postgres is of unlimited size, so I can bump the size to 16,777,215 for instance, and create a migration for MySQL (using MEDIUMTEXT)

Would 16 MiB be a good size, in your opinion?

@de-es
Copy link

de-es commented Dec 29, 2023

IMHO that would be more than enough. Thanks for considering.

@tchapi
Copy link
Owner Author

tchapi commented Dec 29, 2023

→ #127

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tchapi tchapi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tchapi @de-es