Skip to content
This repository has been archived by the owner on Jan 8, 2021. It is now read-only.

Lint fixes #67

Closed
wants to merge 1 commit into from
Closed

Lint fixes #67

wants to merge 1 commit into from

Conversation

kenorb
Copy link
Contributor

@kenorb kenorb commented Dec 11, 2017

Would you consider the following PR as per #66?

It passes all lint checks.

Fixes #66

@nicolas-grekas
Copy link
Contributor

Which feature of the lib are you using?
Can you use https://github.com/symfony/polyfill-iconv/ instead? (and https://github.com/symfony/polyfill-mbstring/ ?)
If yes, that'd be better: this one is in strict maintenance mode, so I'd prefer not patching it as much as possible.

@kenorb
Copy link
Contributor Author

kenorb commented Dec 11, 2017

It's downloaded via dependency from other Composer projects:

composer $ grep -R "patchwork/utf8" **/composer.json
anahkiasen/underscore-php/composer.json:    "patchwork/utf8": "^1.2"
illuminate/support/Illuminate/Support/composer.json:        "patchwork/utf8": "1.1.*",
patchwork/utf8/composer.json:    "name": "patchwork/utf8",
radic/tmp-underscore-php/composer.json:    "patchwork/utf8": "1.0.*"

@nicolas-grekas
Copy link
Contributor

That's an issue with the linter, not with this lib.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fatal error: Cannot redeclare iconv() during lint check
2 participants