Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "complex_logic" issue in src/sqlfmt/line.py #97

Closed
tconbeer opened this issue Jan 28, 2022 · 1 comment
Closed

Fix "complex_logic" issue in src/sqlfmt/line.py #97

tconbeer opened this issue Jan 28, 2022 · 1 comment
Labels
code climate Issues created by, or because of, code climate

Comments

@tconbeer
Copy link
Owner

Consider simplifying this complex logical expression.

https://codeclimate.com/github/tconbeer/sqlfmt/src/sqlfmt/line.py#issue_61f46a9f597a09000100003d
@tconbeer tconbeer added the code climate Issues created by, or because of, code climate label Jan 31, 2022
tconbeer added a commit that referenced this issue Feb 1, 2022
@tconbeer
refactor: simplify line.closes_jinja_block method #97
8d2fdbb
@tconbeer tconbeer mentioned this issue Feb 1, 2022
Merged
tconbeer added a commit that referenced this issue Feb 1, 2022
@tconbeer
chore/sc 210/refactor line py (#108)
2bf487c 
* refactor: create comment.py, add comment tests

* refactor: create node.py

* refactor: simplify line.closes_jinja_block method #97
@tconbeer
Copy link
Owner Author

tconbeer commented Feb 1, 2022

fixed in #108

@tconbeer tconbeer closed this as completed Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code climate Issues created by, or because of, code climate
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tconbeer