Events #4
Merged
Events #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Changed type for `opts` param to `Object`. * Changed type `any` to `*`
The TCP Emitter Broadcast Event should be emitted once all the listeners (TCP Emitter clients) of the event which was broadcasted to, are notified. In order to do this, the net.Socket.write() method had to be promisified for better management.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhance TCP Emitter server so that it emits the following events:
subscribeTCP Emitter clientsubscribes to a TCP Emitter event. The listeners of this event are invoked with theTCP Emitter client&event name. Note when aTCP Emitter clientrequests to subscribe to an event that it is already subscribed to, this event is not emitted.unsubscribeTCP Emitter clientunsubscribes to a TCP Emitter event. The listeners of this event are invoked with theTCP Emitter client&event name. Note when aTCP Emitter clientrequests to unsubscribe from an event that it is not subscribed to, this event is not emitted.broadcastTCP Emitter clientbroadcasts to a TCP Emitter event. The listeners of this event are invoked with theTCP Emitter client,event name&broadcast arguments.