Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Italics, Underline, and Strikethrough support #10

Merged
merged 4 commits into from
Nov 3, 2018
Merged

Conversation

E5ten
Copy link
Contributor

@E5ten E5ten commented Nov 2, 2018

This switches rager to using my ransid fork and makes italics and underline support work. Fixes #8

@E5ten E5ten changed the title Italics and Underline support Italics, Underline, and Strikethrough support Nov 2, 2018
@E5ten
Copy link
Contributor Author

E5ten commented Nov 2, 2018

I added strikethrough support to both ransid and rager, and I installed termite to test it because my terminal doesn't support strikethrough, it worked so I saw no reason not to add it to this.

@tcr tcr merged commit d72039c into tcr:master Nov 3, 2018
@tcr
Copy link
Owner

tcr commented Nov 3, 2018

Checked locally on my machine and it seemed to work with my test script, I think we can merge this as-is. Thanks for the PR!

@tcr
Copy link
Owner

tcr commented Nov 3, 2018

Okay, just discovered I'm blocked on publishing to crates.io until we can no longer rely on a git dependency. So this will have to live in git master until we can upstream the other PR, or the dependent crate is vendored. cargo install --git https://github.com/tcr/rager -f continues to work though.

@E5ten
Copy link
Contributor Author

E5ten commented Nov 3, 2018

I will make a pull request on ransid upstream tomorrow mornin and if it isn't merged after a while I could always make a new crate I guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants