fix compilation with ghc-8.4 #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Now, it should compile with ghc >= 7.8. Would you like an update to travis.yml to test against all ghc versions? |
Sounds lovely. Probably best in a separate PR though. |
tdammers
requested changes
Aug 29, 2018
|
Why not just use `--resolver`?
…On Thu, Aug 30, 2018, 04:21 Vamshi Surabhi ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In stack-ghc-7.10.3.yaml
<#36 (comment)>:
> @@ -0,0 +1,32 @@
+# For more information, see: https://github.com/commercialhaskell/stack/blob/release/doc/yaml_configuration.md
The reason for these files is to test ginger against all ghc versions with
commands:
stack build --fast --test --stack-yaml=stack-ghc-7.8.4.yaml
stack build --fast --test --stack-yaml=stack-ghc-7.10.3.yaml
stack build --fast --test --stack-yaml=stack-ghc-8.0.2.yaml
stack build --fast --test --stack-yaml=stack-ghc-8.2.2.yaml
stack build --fast
How do you prefer testing against different versions of ghc?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#36 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABXjx4jpqqMyzKjO8aAx-zdVRzhdSXYxks5uV0wogaJpZM4WSLws>
.
|
tdammers
approved these changes
Sep 3, 2018
|
Thanks again for doing this. BTW., if you like, add yourself to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR only ensures compilation with ghc >= 8.0, we'll need to follow this if support for ghc < 8.0 is needed.