Add require in the context #13

deniscoman · 2017-09-28T08:14:09Z

Description

Add a "required_params" method to use it like this:

class FindInvoice < UseCase::Base

  required_context :current_user, :invoice_id

  def perform
    ...
  end

end

and when the perform method is called, "context_params" will create instances variables for this params.

Issue

A disscusion about this issue: #9

coveralls · 2017-09-28T08:16:14Z

Coverage increased (+0.08%) to 98.851% when pulling 6af5f5a on deniscoman:required_params into e8329b1 on tdantas:master.

deniscoman · 2017-10-02T11:51:20Z

@tdantas did you look at this?

coveralls · 2017-10-04T12:15:52Z

Coverage increased (+0.07%) to 98.844% when pulling 3dde34f on deniscoman:required_params into e8329b1 on tdantas:master.

…rclasses.

coveralls · 2017-10-10T08:50:12Z

Coverage increased (+0.1%) to 98.883% when pulling 7d75d28 on deniscoman:required_params into e8329b1 on tdantas:master.

pirvudoru · 2017-10-12T13:20:29Z

lib/usecasing/base.rb

      end

      def perform(ctx = { })
        tx(ExecutionOrder.run(self), ctx) do |usecase, context|
          instance = usecase.new(context)
          instance.tap do | me |
+            me.required_params
+            puts self


Please remove the debug statement

pirvudoru · 2017-10-12T13:22:26Z

lib/usecasing/base.rb

      end

      def perform(ctx = { })
        tx(ExecutionOrder.run(self), ctx) do |usecase, context|
          instance = usecase.new(context)
          instance.tap do | me |
+            me.required_params


This should denote an action, probably a better name would be extract_required_params.

Also, i would avoid using require (and any variation) since you don't enforce it, we are just copying the variables from the context to the usecase instance.

Now the method raises an exception when a given parameter does not exist in the context so i think required_params is a good name now.

pirvudoru · 2017-10-12T13:25:00Z

lib/usecasing/base.rb

@@ -31,6 +40,13 @@ def perform(ctx = { })

      private

+      def concat_superclass_variable(variable)


This method does not do any actual concatenation. Please find a better name to describe the action.

I made some changes and I deleted this method.

pirvudoru · 2017-10-12T13:26:01Z

spec/usecase_base_spec.rb

+
+    it 'includes params from the superclasses' do
+      AppUseCase = Class.new(UseCase::Base) do
+        required_params :param


Please rename required_params in order to denote an action.

pirvudoru · 2017-10-12T13:26:24Z

spec/usecase_base_spec.rb

@@ -66,6 +92,19 @@ def perform
      expect(ctx.email).to eql('thiago.teixeira.dantas@gmail.com')
    end

+    it 'receives a hash and return it' do
+


Remove empty line.

pirvudoru · 2017-10-12T13:26:29Z

spec/usecase_base_spec.rb

+      UseCaseSubClass = Class.new(AppUseCase)
+
+      expect(UseCaseSubClass.required_params).to eql([:param])
+


Remove empty line

pirvudoru · 2017-10-12T13:26:43Z

spec/usecase_base_spec.rb

@@ -40,6 +40,32 @@

  end

+  context "required_params" do
+


Remove empty line

pirvudoru · 2017-10-12T13:27:10Z

spec/usecase_base_spec.rb

@@ -85,7 +124,7 @@ def perform
      pending
    end

-    it 'fail when usecase register failure' do 
+    it 'fail  when usecase register failure' do


Remove extra space

Done. Thanks.

coveralls · 2017-10-17T08:03:21Z

Coverage increased (+0.1%) to 98.88% when pulling 76211d1 on deniscoman:required_params into e8329b1 on tdantas:master.

…es not exist in the context.

coveralls · 2017-10-17T09:44:09Z

Coverage increased (+0.1%) to 98.88% when pulling 7a30c74 on deniscoman:required_params into e8329b1 on tdantas:master.

pirvudoru

👍

coveralls · 2017-10-18T12:53:34Z

Coverage increased (+0.2%) to 98.936% when pulling c9ff87a on deniscoman:required_params into e8329b1 on tdantas:master.

coveralls · 2017-10-18T13:59:36Z

Coverage decreased (-0.08%) to 98.691% when pulling 7f2df9d on deniscoman:required_params into e8329b1 on tdantas:master.

deniscoman · 2017-10-18T16:48:47Z

@tdantas any opinion about this?

Add require in the context

6af5f5a

Fix a bug that context params didn't receive required params

3dde34f

Add support for superclasses. Required parms should inherit form supe…

7d75d28

…rclasses.

pirvudoru suggested changes Oct 12, 2017

View reviewed changes

Raise ArgumentException when a given parameter for required_params do…

7a30c74

…es not exist in the context.

deniscoman force-pushed the required_params branch from 76211d1 to 7a30c74 Compare October 17, 2017 09:41

pirvudoru approved these changes Oct 17, 2017

View reviewed changes

Add optional_params for context variables that are not required

7f2df9d

deniscoman force-pushed the required_params branch from c9ff87a to 7f2df9d Compare October 18, 2017 13:57

deniscoman closed this Jan 14, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add require in the context #13

Add require in the context #13

deniscoman commented Sep 28, 2017

coveralls commented Sep 28, 2017

deniscoman commented Oct 2, 2017 •

edited

Loading

coveralls commented Oct 4, 2017

coveralls commented Oct 10, 2017

pirvudoru Oct 12, 2017

deniscoman Oct 17, 2017

pirvudoru Oct 12, 2017

pirvudoru Oct 12, 2017

deniscoman Oct 17, 2017

pirvudoru Oct 12, 2017

deniscoman Oct 13, 2017 •

edited

Loading

pirvudoru Oct 12, 2017

pirvudoru Oct 12, 2017

deniscoman Oct 17, 2017

pirvudoru Oct 12, 2017

deniscoman Oct 17, 2017

pirvudoru Oct 12, 2017

deniscoman Oct 17, 2017

pirvudoru Oct 12, 2017

deniscoman Oct 17, 2017

coveralls commented Oct 17, 2017

coveralls commented Oct 17, 2017

pirvudoru left a comment

coveralls commented Oct 18, 2017

coveralls commented Oct 18, 2017

deniscoman commented Oct 18, 2017

		@@ -31,6 +40,13 @@ def perform(ctx = { })

		private

		def concat_superclass_variable(variable)

		UseCaseSubClass = Class.new(AppUseCase)

		expect(UseCaseSubClass.required_params).to eql([:param])

Add require in the context #13

Add require in the context #13

Conversation

deniscoman commented Sep 28, 2017

Description

Issue

coveralls commented Sep 28, 2017

deniscoman commented Oct 2, 2017 • edited Loading

coveralls commented Oct 4, 2017

coveralls commented Oct 10, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

deniscoman Oct 13, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coveralls commented Oct 17, 2017

coveralls commented Oct 17, 2017

pirvudoru left a comment

Choose a reason for hiding this comment

coveralls commented Oct 18, 2017

coveralls commented Oct 18, 2017

deniscoman commented Oct 18, 2017

deniscoman commented Oct 2, 2017 •

edited

Loading

deniscoman Oct 13, 2017 •

edited

Loading