Fix reversing adapter identifiers in place #1875
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Kudos to @CarlosCortizasCT for finding this bug.
We reversed the React context in place. Turns out you can do that 😓.
The commits for each package contain a broken test suite and then the fix. Sort of Uni-style TDD to prove the point.
The setup of how we test had to be adjusted as we want to test this with combined adapters.