Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reversing adapter identifiers in place #1875

Merged
merged 5 commits into from
Mar 16, 2024
Merged

Conversation

tdeekens
Copy link
Owner

Summary

Kudos to @CarlosCortizasCT for finding this bug.

We reversed the React context in place. Turns out you can do that 😓.

The commits for each package contain a broken test suite and then the fix. Sort of Uni-style TDD to prove the point.

The setup of how we test had to be adjusted as we want to test this with combined adapters.

Copy link

changeset-bot bot commented Mar 16, 2024

🦋 Changeset detected

Latest commit: a199e31

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@flopflip/combine-adapters Patch
@flopflip/react-broadcast Patch
@flopflip/react-redux Patch
@flopflip/react Patch
@flopflip/test-utils Patch
@flopflip/adapter-utilities Patch
@flopflip/cypress-plugin Patch
@flopflip/graphql-adapter Patch
@flopflip/http-adapter Patch
@flopflip/launchdarkly-adapter Patch
@flopflip/localstorage-adapter Patch
@flopflip/localstorage-cache Patch
@flopflip/memory-adapter Patch
@flopflip/sessionstorage-cache Patch
@flopflip/splitio-adapter Patch
@flopflip/types Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Mar 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.23%. Comparing base (70e08ec) to head (f7d07a4).

❗ Current head f7d07a4 differs from pull request most recent head a199e31. Consider uploading reports for the commit a199e31 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1875      +/-   ##
==========================================
+ Coverage   93.22%   93.23%   +0.01%     
==========================================
  Files         109      109              
  Lines        1742     1745       +3     
  Branches      254      255       +1     
==========================================
+ Hits         1624     1627       +3     
  Misses        118      118              
Files Coverage Δ
...use-all-feature-toggles/use-all-feature-toggles.ts 100.00% <100.00%> (ø)
...use-all-feature-toggles/use-all-feature-toggles.ts 100.00% <100.00%> (ø)
packages/test-utils/src/index.js 96.29% <100.00%> (+0.06%) ⬆️

@tdeekens tdeekens merged commit 6672683 into main Mar 16, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant