Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(http-adapter): to not empty flags with unchanged reconfiguration #1906

Merged
merged 2 commits into from
May 16, 2024

Conversation

tdeekens
Copy link
Owner

Summary

The launchdarkly-adapter does not perform any action with reconfiguring on an unchanged user context.

The http-adapter should perform similar. We do not need to empty the cache and refetch. We can just perform no action in this case.

Copy link

changeset-bot bot commented May 16, 2024

🦋 Changeset detected

Latest commit: fdb4eff

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 17 packages
Name Type
@flopflip/http-adapter Patch
@flopflip/launchdarkly-adapter Patch
@flopflip/adapter-utilities Patch
@flopflip/cache Patch
@flopflip/combine-adapters Patch
@flopflip/cypress-plugin Patch
@flopflip/graphql-adapter Patch
@flopflip/localstorage-adapter Patch
@flopflip/localstorage-cache Patch
@flopflip/memory-adapter Patch
@flopflip/react-broadcast Patch
@flopflip/react-redux Patch
@flopflip/react Patch
@flopflip/sessionstorage-cache Patch
@flopflip/splitio-adapter Patch
@flopflip/test-utils Patch
@flopflip/types Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.89%. Comparing base (bc025ef) to head (fdb4eff).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1906      +/-   ##
==========================================
+ Coverage   93.84%   93.89%   +0.05%     
==========================================
  Files         109      109              
  Lines        1754     1754              
  Branches      266      267       +1     
==========================================
+ Hits         1646     1647       +1     
+ Misses        108      107       -1     
Files Coverage Δ
packages/http-adapter/src/adapter/adapter.ts 85.93% <100.00%> (+0.11%) ⬆️
...ckages/launchdarkly-adapter/src/adapter/adapter.ts 95.97% <ø> (+0.54%) ⬆️

@tdeekens tdeekens merged commit d4079b3 into main May 16, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant