-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dynamicadaptiveparameters #19
Conversation
ok to review it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments
Hopefully these methods still work OK and give sensible results? (eg you could check by putting in print statements to check the values of self.bandwidth) |
alpha, bandwidth do get updated when this function "kde.set_adaptive_parameter(newalp, newbw)" is called but printing kde.bandwidth returns just updated global bandwidth but not an array. |
I fixed the docstring and comment formats but it would be good if you remember to use numpy style comments / docstrings. |
for issue 17: add methods which allow the values to be changed and also redo the necessary adaptive fitting steps