Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dynamicadaptiveparameters #19

Merged
merged 12 commits into from
Apr 8, 2024
Merged

dynamicadaptiveparameters #19

merged 12 commits into from
Apr 8, 2024

Conversation

JAMSADIQ
Copy link
Collaborator

for issue 17: add methods which allow the values to be changed and also redo the necessary adaptive fitting steps

@JAMSADIQ JAMSADIQ requested a review from tdent March 25, 2024 13:09
popde/adaptive_kde.py Outdated Show resolved Hide resolved
@JAMSADIQ JAMSADIQ requested a review from tdent March 29, 2024 10:10
@JAMSADIQ
Copy link
Collaborator Author

JAMSADIQ commented Apr 4, 2024

ok to review it.

popde/adaptive_kde.py Outdated Show resolved Hide resolved
popde/adaptive_kde.py Outdated Show resolved Hide resolved
Copy link
Owner

@tdent tdent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

popde/adaptive_kde.py Outdated Show resolved Hide resolved
@tdent
Copy link
Owner

tdent commented Apr 8, 2024

Hopefully these methods still work OK and give sensible results? (eg you could check by putting in print statements to check the values of self.bandwidth)

@JAMSADIQ
Copy link
Collaborator Author

JAMSADIQ commented Apr 8, 2024

alpha, bandwidth do get updated when this function "kde.set_adaptive_parameter(newalp, newbw)" is called but printing kde.bandwidth returns just updated global bandwidth but not an array.

@tdent
Copy link
Owner

tdent commented Apr 8, 2024

I fixed the docstring and comment formats but it would be good if you remember to use numpy style comments / docstrings.

@tdent tdent merged commit 8ebeb1b into tdent:main Apr 8, 2024
@JAMSADIQ JAMSADIQ deleted the issue17 branch July 22, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants