Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Octal escape sequences are not allowed #577

Closed
sank3 opened this issue May 10, 2023 · 2 comments
Closed

Octal escape sequences are not allowed #577

sank3 opened this issue May 10, 2023 · 2 comments

Comments

@sank3
Copy link

sank3 commented May 10, 2023

When I compress a JS file, It gives a syntax error when the JS is loaded in a browser.

Uncaught SyntaxError: Octal escape sequences are not allowed in strict mode. (at pdf-worker-min.js:28:110842)

I have attached the original and minified files here.

files.zip

Module version v2.12.5
Golang 1.18
@tdewolff
Copy link
Owner

I've pushed a fix where escaped NULL characters are now replaced with a literal NULL. Can you please check if this works before I push out a new version?

@sank3
Copy link
Author

sank3 commented May 16, 2023

works just fine. thank you.

tdewolff added a commit that referenced this issue Jun 19, 2023
@tdewolff
JS: don't convert \0,\x00,\u0000 to literal NULL as it breaks RegExp;…
bf2187d 
… convert \x00,\u0000 to \0 only if it can't possibly be an octal escape sequence (see #577); fixes #585
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tdewolff @sank3