WARNING: preserve ownership not supported on platform

[c9845]

Over the last month or so, I have been receiving a 'WARNING: preserve ownership not supported on platform' warning when using the minify binary to compress files. I also get a resulting spike in CPU usage (the messages are logged constantly until the process is killed). I receive this message when minifying CSS or JS, using a command such as follows:
minify -w -v -o website/static/css/styles.min.css website/static/css/styles.css. Note, however, that minifying does work, most of the time, unless CPU is exhausted.

I cannot identify what the issue is, or why it started occurring. I have used minify in my development process for a long time without issue. I tried to do some debugging without success.

I am running W11 22H2 (this occurred on 22H1 too).
I installed minify using go install github.com/tdewolff/minify/v2/cmd/minify@latest.
I am on the latest version of minify.

[c9845]

I just did some manual bisecting of releases to see (1) if this was related to a change in minify or Windows, and (2) to see if there was a specific minify version where this cropped up.

The issue starts occurring at minify version v2.19.10. It does not occur at v2.12.9.

I haven't diff-ed the versions yet, or dug into the code, to identify an issue in the code, but this clearly aligns with something in preserveAttributes().

[c9845]

Reference: --preserve or -p flag to minify....

[c9845]

It looks like the default --preserve value was changed, although I am not entirely sure.

In v2.12.9 is was nil. In v2.19.10 is was changed to []string{"mode", "ownership", "timestamps"}. However, in the non-warning-logging v2.12.9 there is a f.Lookup().NoOptDefVal that looks like it is applying a default value anyway. I am assuming this NoOptDefVal was broken and the default was just applied to the --preserve flag parsing?

Commit 38f0e88 removed the NoOptDefVal.

[tdewolff]

Thanks for the bug report. There was a big change in library for the commit you reference, from using spf13's pflag to my own argp. Before, the default value when not supplied was nil which was then set to mode, ownership, timestamps using the NoOptDefVal you mention, and that should still be the case. So I'm not sure why this behaviour changed for you...!

You can remove the -v flag to prevent logging warnings. Are you minifying many files? That would explain the CPU spike, I think we should log warnings only once (fixed in 729b3d1). Otherwise, the fix would be to use --preserve=[mode timestamps] since preserving ownership on Window sis not supported (yet).

[tdewolff]

Changed that if getting/setting ownership is not supported on platform, the default value for --preserve is now mode,timestamps

[c9845]

I saw that the previous setting for --preserve was nil which then got set to mode, ownership, timestamps but for some reason this error does not occur. It have a feeling nil is being used instead of the NoOptDefVal. Regardless, that is in an old version of this....

I did start using the --preserve flag so that solves my issue! The new functionality to automatically determine if "ownership" is supported is even better! Much appreciated.

---

I am not minifying a lot of files. One .css to .min.css. My CPU just sits at 25%+ for the minify process. I am not sure what it is doing!

[tdewolff]

You minify only one file? How big is it? How long does it take to minify? I suppose you have 4 CPU cores which means it is working full for that file. It should take a split-second, so this may be a bug in the CSS minifier. If that is the case, could you send me the file to fix the bug?

…

On Mon, Dec 11, 2023, 19:13 c9845 ***@***.***> wrote: I saw that the previous setting for --preserve was nil which then got set to mode, ownership, timestamps but for some reason this error does not occur. It have a feeling nil is being used instead of the NoOptDefVal. Regardless, that is in an old version of this.... I did start using the --preserve flag so that solves my issue! The new functionality to automatically determine if "ownership" is supported is even better! Much appreciated. ------------------------------ I am not minifying a lot of files. One .css to .min.css. My CPU just sits at 25%+ for the minify process. I am not sure what it is doing! — Reply to this email directly, view it on GitHub <#646 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABKOGHUHVV7D3ZF3N67ED2DYI6ASDAVCNFSM6AAAAABAQJPHUKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJQHE3TMMZQHA> . You are receiving this because you commented.Message ID: ***@***.***>

[tdewolff]

I'm pretty sure the problem is a little further down in the function, where I compare the root path with the src path, and unless they are equal it goto the beginning. In Windows the paths never match due to the forward backward slash difference.

No need to send me the file thus, let me work on a fix and I'll need you to verify it's working, thanks!

[c9845]

Taco,
I am going to open a new issue for the high CPU usage to keep the issues more singular focused...

Plus, it looks like the "preserve ownership" sort-of-a-bug has been fixed.

[tdewolff]

Alright, in the mean time I've pushed out a (possible) fix for the endless loop. Are you able to test from the master branch? You need to clone the repository and run make install in the repo directory (or othersider go to cmd/minify/ and run go install). Thanks!

[c9845]

I cloned the repo and tested. The --preserve issue is fixed!