Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect permissions in Python bindings Workflow #622

Merged
merged 2 commits into from
Oct 30, 2023

Conversation

pydsigner
Copy link
Contributor

See softprops/action-gh-release#232. Previous workflow setup was working for pushes but not in our current setup with releases.

@codecov-commenter
Copy link

codecov-commenter commented Oct 29, 2023

Codecov Report

Merging #622 (99a0f77) into master (ef07b85) will not change coverage.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@           Coverage Diff           @@
##           master     #622   +/-   ##
=======================================
  Coverage   83.75%   83.75%           
=======================================
  Files          25       25           
  Lines        6772     6772           
=======================================
  Hits         5672     5672           
  Misses       1023     1023           
  Partials       77       77           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pydsigner
Copy link
Contributor Author

pydsigner commented Oct 30, 2023

I feel I was negligent not to test prior to we merged the prior PR, so I made a dummy release on my fork this time. Looks like this patch works: https://github.com/pydsigner/minify/actions/runs/6687375619

I need to see if it's possible to edit the failed workflow from the already existing tdewolff-minify release so we can get the wheels published to PyPI without making a new release.

@pydsigner
Copy link
Contributor Author

Rerunning with the fix might not be possible, but we could grab the wheels that will be generated in my test run and upload them manually to the GitHub release and PyPI.

@tdewolff tdewolff merged commit 20963b9 into tdewolff:master Oct 30, 2023
9 checks passed
@tdewolff
Copy link
Owner

Thanks for the fix, I'll be releasing a new version in a minute!

@pydsigner
Copy link
Contributor Author

pydsigner commented Oct 30, 2023

@tdewolff I wish I had gotten back to this sooner. It takes a long time for the arm64 binaries to build so I didn't see the final release stage run; when it did, I found an issue in the publishing step. However, the wheels will available in the Workflow of your run once it completes. In the meantime, I will look deeper into how to get download-artifact to do what I want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants