cppcheck: fix useStlAlgorithm #59
Conversation
src/libcmis/gdrive-document.cxx:76:13: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] src/libcmis/gdrive-document.cxx:89:0: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] src/libcmis/gdrive-document.cxx:95:0: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] src/libcmis/json-utils.cxx:164:14: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm]
src/libcmis/gdrive-document.cxx
Outdated
| @@ -69,35 +70,48 @@ string GDriveDocument::getDownloadUrl( string streamId ) | |||
| if ( !streamId.empty( ) ) | |||
| { | |||
| // Find the rendition associated with the streamId | |||
| for ( vector< RenditionPtr >::iterator it = renditions.begin( ) ; | |||
| it != renditions.end(); ++it ) | |||
| std::vector<RenditionPtr>::iterator it = std::find_if(renditions.begin(), renditions.end(), | |||
There was a problem hiding this comment.
TBH, I don't think this improves the code in any way... If you really want to touch this, maybe using foreach loops would be better? That should make the code easier to read.
There was a problem hiding this comment.
Just to be sure, before I do anything wrong, do you prefer a foreach for the 4 changes or only for this one?
src/libcmis/gdrive-document.cxx:76:13: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] src/libcmis/gdrive-document.cxx:89:0: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] src/libcmis/gdrive-document.cxx:95:0: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] src/libcmis/json-utils.cxx:164:14: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm]
… into useStlAlgorithm
… into useStlAlgorithm
… into useStlAlgorithm
src/libcmis/gdrive-document.cxx
Outdated
| if ( (*it)->getMimeType( ).find( "opendocument") != string::npos ) | ||
| return (*it)->getUrl( ); | ||
| for (const auto& renditionPtr : renditions) | ||
| { |
There was a problem hiding this comment.
Please don't add extra braces unless needed.
src/libcmis/gdrive-document.cxx
Outdated
| @@ -69,35 +69,39 @@ string GDriveDocument::getDownloadUrl( string streamId ) | |||
| if ( !streamId.empty( ) ) | |||
| { | |||
| // Find the rendition associated with the streamId | |||
| for ( vector< RenditionPtr >::iterator it = renditions.begin( ) ; | |||
| it != renditions.end(); ++it ) | |||
| for (const auto& renditionPtr : renditions) | |||
There was a problem hiding this comment.
Please try to follow the coding style of the surrounding code. (I don't like it very much myself, but, on my list, consistency is higher than personal preference.)
There was a problem hiding this comment.
Not sure to understand here, do you mean I should use:
for (const auto& renditionPtr
: renditions)
?
There was a problem hiding this comment.
No, that doesn't make much sense. What I mean is: try to use the same indentation, spaces around stuff, etc. like the surrounding code. E.g.,
if ( renditionPtr->getStreamId( ) == streamId )instead of
if (renditionPtr->getStreamId() == streamId)There was a problem hiding this comment.
Ok I added spaces on all locations I had changed.
Hope it's ok now.
src/libcmis/gdrive-document.cxx
Outdated
| @@ -27,6 +27,7 @@ | |||
| */ | |||
|
|
|||
| #include "gdrive-document.hxx" | |||
| #include <algorithm> | |||
There was a problem hiding this comment.
Also, please use git commit --amend or git rebase --interactive to make "perfect" commits (followed by git push --force).
There was a problem hiding this comment.
I tried too but sometimes the push is rejected on my local branch.
This time it seemed ok.
… into useStlAlgorithm
… into useStlAlgorithm
|
Is there anything I should change or is it ok? |
… into useStlAlgorithm
… into useStlAlgorithm
src/libcmis/gdrive-document.cxx:76:13: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm]
src/libcmis/gdrive-document.cxx:89:0: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm]
src/libcmis/gdrive-document.cxx:95:0: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm]
src/libcmis/json-utils.cxx:164:14: style: Consider using std::transform algorithm instead of a raw loop. [useStlAlgorithm]