Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Animint fun #171

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Animint fun #171

wants to merge 6 commits into from

Conversation

tdhock
Copy link
Owner

@tdhock tdhock commented Nov 2, 2016

rather than explicitly writing structure(list(...), class="animint") we can write animint(...)

tdhock
tdhock commented Nov 2, 2016
View reviewed changes
inst/examples/test_knit_print.Rmd
structure(q2, class = "animint")
animint(q = qplot(
x, y, data = dat, colour = label,
xlab = "first plot with color legend"))
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here I add a test for the new functionality in the existing test for rendering Rmd

@tdhock
Copy link
Owner Author

tdhock commented Nov 3, 2016

hey @cpsievert any comments about this new functionality? I remember during your GSOC you said that you would rather be explicit and use structure to attach a class to an animint viz list. However, during my interactive graphics tutorial at useR2016, one of the people suggested to have a function like this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tdhock